fix: Correct Elasticsearch docs for 10k row cap, object type mapping, and timeout#1662
Merged
Merged
Conversation
The metric types for `replication_bootstrap_rows_total` and `replication_bootstrap_complete` were swapped. Per the source implementation, `replication_bootstrap_rows_total` is an ObservableCounter (not ObservableGauge) and `replication_bootstrap_complete` is an ObservableGauge (not ObservableCounter).
…e mapping, and timeout description - Document the 10,000-row hard cap on query results in both the connector index and deployment guide. The connector clamps the Elasticsearch `size` parameter to 10,000 regardless of SQL LIMIT. - Split the `object`/`nested` type mapping table row: object fields with sub-properties are flattened into dot-separated columns, not serialized as JSON. Only object fields without sub-fields and `nested` fields become Utf8 JSON strings. - Fix the request timeout description: the 30s timeout applies per individual HTTP request, not "including retries" (read operations do not retry).
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://70e18963.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.max_result_window), even when SQLLIMITis higher or omitted. This was undocumented. Added this as a limitation in the connector index page and updated the deployment guide's "Result size" bullet to call out the hard cap.objecttype mapping: The type mapping table incorrectly showedobjectfields asUtf8(serialized JSON). In practice,objectfields with sub-properties are flattened into dot-separated columns (e.g.address.city), which the prose below the table already stated. Split the table row to distinguishobject(with sub-fields) fromobject(no sub-fields) andnested.bulk_indexpath retries. Changed to "Maximum time for each individual HTTP request."Test plan